Temporarily override GPU base AMI #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrc
reviewed
Nov 6, 2023
sparrc
previously approved these changes
Nov 6, 2023
chienhanlin
reviewed
Nov 6, 2023
| @@ -84,6 +85,7 @@ source_ami_al2 = "$ami_name_al2_x86" | |||
| source_ami_al2arm = "$ami_name_al2_arm" | |||
| source_ami_al2kernel5dot10 = "$ami_name_al2_kernel5dot10" | |||
| source_ami_al2kernel5dot10arm = "$ami_name_al2_kernel5dot10arm" | |||
| source_ami_al2_gpu = "amzn2-ami-minimal-hvm-2.0.20230926.0-x86_64-ebs" | |||
There was a problem hiding this comment.
Maybe we don't need to update generate-release-vars.sh since the default value for source_ami_al2_gpu is defined in variables.pkr.hcl?
variable "source_ami_al2_gpu" {
type = string
description = "Amazon Linux 2 source AMI to build AL2GPU AMI from. This is a temporary override."
default = "amzn2-ami-minimal-hvm-2.0.20230926.0-x86_64-ebs"
}
There was a problem hiding this comment.
True. This is writing to the release.autopkrvars.hcl so that releaser can see the diff and write change log though, so I would not think it is a big deal to keep it.
sparrc
approved these changes
Nov 7, 2023
amogh09
approved these changes
Nov 7, 2023
singholt
approved these changes
Nov 7, 2023
Merged
hozkaya2000
pushed a commit
that referenced
this pull request
Nov 8, 2023
rwarren25
pushed a commit
to rwarren25/amazon-ecs-ami
that referenced
this pull request
Jul 9, 2024
rwarren25
pushed a commit
to rwarren25/amazon-ecs-ami
that referenced
this pull request
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Temporarily override base AMI for AL2 GPU due to a known al2 kernel and EFA/Nvidia incompatibility
Implementation details
Add a variable and change al2gpu recipe to use a pinned al2 base AMI.
Testing
New tests cover the changes: N/A
Ran
REGION=us-west-2 make al2gpuand verified a pinned base AMI is used (ami-0bac1825e471f5042)Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.